Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix and validate "version" field while importing metadata in local monitoring #1217

Open
shreyabiradar07 opened this issue Jun 27, 2024 · 0 comments
Open

Fix and validate "version" field while importing metadata in local monitoring #1217

shreyabiradar07 opened this issue Jun 27, 2024 · 0 comments
Assignees
@shreyabiradar07
Labels
bug Something isn't working kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase test

Comments

@shreyabiradar07
Copy link
Contributor

Currently version is not used in the current local monitoring datasource codeflow and hence POST /dsmetadata API passes and imports metadata successfully even with blank and invalid input json version field values.

Associated test case failure in local_monitoring_tests:
rest_apis.test_import_metadata.test_import_metadata_invalid_test[blank_version-400--prometheus-1]
rest_apis.test_import_metadata.test_import_metadata_invalid_test[invalid_version-400-xyz-prometheus-1]
@shreyabiradar07 shreyabiradar07 self-assigned this Jun 27, 2024
@shreyabiradar07 shreyabiradar07 added enhancement New feature or request test kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase bug Something isn't working and removed enhancement New feature or request labels Jun 27, 2024
@shreyabiradar07 shreyabiradar07 moved this to Todo in Monitoring Jun 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@shreyabiradar07 shreyabiradar07

Labels
bug Something isn't working kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase test
Projects
Monitoring
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shreyabiradar07