From 1bc7d44ce9cdf557841e818416565e49af67e10a Mon Sep 17 00:00:00 2001 From: Electronic-Waste <2690692950@qq.com> Date: Sun, 2 Mar 2025 07:45:47 +0000 Subject: [PATCH] fix(test): update job to indexed job. Signed-off-by: Electronic-Waste <2690692950@qq.com> --- .../trial/trial_controller_test.go | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/pkg/controller.v1beta1/trial/trial_controller_test.go b/pkg/controller.v1beta1/trial/trial_controller_test.go index d3794f1fd1b..7401b3dc31c 100644 --- a/pkg/controller.v1beta1/trial/trial_controller_test.go +++ b/pkg/controller.v1beta1/trial/trial_controller_test.go @@ -57,6 +57,7 @@ const ( var ( startTime = time.Now() + completionTime = time.Now().Add(time.Second) batchJobKey = types.NamespacedName{Name: batchJobName, Namespace: namespace} observationLogAvailable = &api_pb.GetObservationLogReply{ ObservationLog: &api_pb.ObservationLog{ @@ -218,7 +219,8 @@ func TestReconcileBatchJob(t *testing.T) { Reason: batchJobCompleteReason, }, }, - StartTime: &metav1.Time{Time: startTime}, + StartTime: &metav1.Time{Time: startTime}, + CompletionTime: &metav1.Time{Time: completionTime}, } g.Expect(c.Status().Update(ctx, batchJob)).NotTo(gomega.HaveOccurred()) @@ -465,6 +467,17 @@ func newFakeTrialBatchJob(mcType commonv1beta1.CollectorKind, trialName string) Namespace: namespace, }, Spec: batchv1.JobSpec{ + CompletionMode: ptr.To(batchv1.IndexedCompletion), + Completions: ptr.To(int32(1)), + Parallelism: ptr.To(int32(1)), + SuccessPolicy: &batchv1.SuccessPolicy{ + Rules: []batchv1.SuccessPolicyRule{ + { + SucceededIndexes: ptr.To("0"), + SucceededCount: ptr.To(int32(1)), + }, + }, + }, Template: corev1.PodTemplateSpec{ Spec: corev1.PodSpec{ Containers: []corev1.Container{