Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

1.9.0 manifests use LATEST tag for Kubeflow Notebooks! #2849

Closed
5 of 7 tasks
thesuperzapper opened this issue Aug 20, 2024 · 3 comments · Fixed by #2853
Closed
5 of 7 tasks

1.9.0 manifests use LATEST tag for Kubeflow Notebooks! #2849

thesuperzapper opened this issue Aug 20, 2024 · 3 comments · Fixed by #2853

Comments

@thesuperzapper
Copy link
Member

thesuperzapper commented Aug 20, 2024

Validation Checklist

Version

1.9

Describe your issue

For some reason the Kubeflow Notebooks spawner_ui_config.yaml was not correctly synced from the kubeflow/kubeflow repo, resulting in the default spawner using the :latest tag, rather than the correct :1.9.0 tag.

https://github.com/kubeflow/manifests/blob/v1.9.0/apps/jupyter/jupyter-web-app/upstream/base/configs/spawner_ui_config.yaml

This is a CRITICAL issue which must be rectified by a 1.9.1 release almost immediately, as it will inevitably result in many users using unstable Notebook images without realizing it, as we use latest for all dev builds.

Steps to reproduce the issue

N/A

Put here any screenshots or videos (optional)

No response

@thesuperzapper
Copy link
Member Author

thesuperzapper commented Aug 20, 2024

@juliusvonkohout @kubeflow/release-managers @kubeflow/release-team this is a critical issue for 1.9.1, and its so serious that we should consider releasing a fix with only this.

The only other things which we probably need in that emergency 1.9.1 release would be fixing the regressions which make the Kubeflow Pipelines SDK authentication no longer work:

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Aug 20, 2024

Yes, this was discussed a few weeks ago in the release team meetings and we also have #2804

I also talked about it with @kimwnasptd and hope that he can fix it more easily since he has access to both repositories to adjust the synchronization scripts and structure.

@juliusvonkohout
Copy link
Member

Please check #2853

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants