Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: support ubuntu 2404 in azure gen2 VMs #425

Closed
wants to merge 1 commit into from
Closed

fix: support ubuntu 2404 in azure gen2 VMs #425

wants to merge 1 commit into from

Conversation

dharapvj
Copy link

What this PR does / why we need it:
Brings compatibility for ubuntu 2404 edition to Azure

Which issue(s) this PR fixes:

Fixes #398

What type of PR is this?

/kind bug
/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. labels Oct 28, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. label Oct 28, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cnvergence for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2024
@ahmedwaleedmalik
Copy link
Member

Is this PR still relevant?

@dharapvj
Copy link
Author

dharapvj commented Dec 4, 2024

I guess, in current state and form - changes brought by this PR will not work in many other (non-Azure) environments, correct?

If so - lets close it.

@ahmedwaleedmalik
Copy link
Member

I guess, in current state and form - changes brought by this PR will not work in many other (non-Azure) environments, correct?

If so - lets close it.

Yes, it won't work.

@dharapvj
Copy link
Author

dharapvj commented Dec 4, 2024

/close - this approach will not work at other cloud providers.

@dharapvj dharapvj closed this Dec 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. kind/chore Updating grunt tasks etc; no production code changes. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ubuntu 2404 broken on Azure
3 participants
@dharapvj @kubermatic-bot @ahmedwaleedmalik