Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consistent Logging #1806

Closed
devigned opened this issue Oct 28, 2021 · 0 comments · Fixed by #1812
Closed

Consistent Logging #1806

devigned opened this issue Oct 28, 2021 · 0 comments · Fixed by #1812
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@devigned
Copy link
Contributor

/kind feature

I've found there are 3 ways we are currently logging.

  1. directly via klog
  2. via the logger on scopes
  3. via the span logger

We should have a single consistent pattern for logging to improve the consistency of the code, but more so, to improve the logging experience for the operator of CAPZ.

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What did you expect to happen:
I'd like to see that we consistently use the span logger, so that spans will be sent to both STDOUT, but also as events on our distributed traces spans. The span logger is directly tied to the context. In funcs where there is no context, we should provide the logger or the context as a argument.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants