Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Webhooks should handle dry run enabled admission requests #5373

Open
nawazkh opened this issue Jan 16, 2025 · 0 comments
Open

Webhooks should handle dry run enabled admission requests #5373

nawazkh opened this issue Jan 16, 2025 · 0 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nawazkh
Copy link
Member

nawazkh commented Jan 16, 2025

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

  • As of CAPZ v1.17.2, CAPZ uses custom Defaulter and Custom Validator for handling mutating and validating requests.
  • The admission requests are not handled by CAPZ, instead the Default, Create, Update and Delete methods are implemented by CAPZ webhooks.
  • While this implementation enables CAPZ to maintain just-required methods, CAPZ webhooks cannot differentiate if the admission request was of Type DryRun.
  • To be able to understand if the admission request is of type DryRun, CAPZ webhooks should have access to the complete admission request object.
  • This issue serves as a reminder to probe this proposal.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 16, 2025
@nawazkh nawazkh self-assigned this Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Todo
Development

No branches or pull requests

2 participants