Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

controllers: non-empty reconcile result and error #1838

Closed
EmilienM opened this issue Jan 24, 2024 · 2 comments · Fixed by #1839
Closed

controllers: non-empty reconcile result and error #1838

EmilienM opened this issue Jan 24, 2024 · 2 comments · Fixed by #1839
Assignees
@EmilienM
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@EmilienM
Copy link
Contributor

EmilienM commented Jan 24, 2024 •
edited
Loading

/kind bug

Since controller-runtime kubernetes-sigs/controller-runtime#2451, a warning will be logged when the OpenStack controllers is preparing the bastion VM, which was returning an error and a non-zero result.

Side note:
We also saw infinite retries using the same reconcile ID, this might or might not be related to that issue.
EDIT: I saw it in old jobs (from like a month ago) where the reconcileID was re-used thousands of times; I guess this is normal.
EDIT2: It's a real issue: #1840
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 24, 2024
@EmilienM EmilienM changed the title Fix returning non-empty reconcile result and error OpenStackCluster controller: non-empty reconcile result and error Jan 24, 2024
@EmilienM EmilienM mentioned this issue Jan 24, 2024
Merged
@EmilienM
Copy link
Contributor Author

/assign EmilienM

@EmilienM EmilienM changed the title OpenStackCluster controller: non-empty reconcile result and error controllers: non-empty reconcile result and error Jan 24, 2024
@EmilienM EmilienM mentioned this issue Jan 25, 2024
Closed
@EmilienM
Copy link
Contributor Author

@kubernetes-sigs/cluster-api-provider-openstack-maintainers please add v1beta1 to milestone.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@EmilienM EmilienM

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
2 participants
@EmilienM @k8s-ci-robot