Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Incorrect ControlPlaneEndpoint printer column #3362

Open
panuhorsmalahti opened this issue Feb 19, 2025 · 2 comments
Open

Incorrect ControlPlaneEndpoint printer column #3362

panuhorsmalahti opened this issue Feb 19, 2025 · 2 comments

Comments

@panuhorsmalahti
Copy link

The ControlPlaneEndpoint in additionalPrinterColumns of the CustomResourceDefinition has a jsonPath of .spec.controlPlaneEndpoint[0], but I think it's incorrect as .spec.controlPlaneEndpoint is an object. I would therefore assume this should be .spec.controlPlaneEndpoint.

Environment:

  • Cluster-api-provider-vsphere version: main branch
@chrischdi
Copy link
Member

chrischdi commented Feb 19, 2025 •
edited
Loading

I agree, we should fix that.

@sbueringer
Copy link
Member

Makes sense. We should check how the column turns out. Maybe we have to combine .host & .port somehow

Feel free to give it a try and open a PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrischdi @panuhorsmalahti @sbueringer