Skip to content

Commit 1a9e63e

Browse files
committed
Fix checker set
Some of the enabled checkers were deprecated, had known issues, or returned erroneous results. They've been commented out, with comments as to why they're not run.
1 parent 56a7fb2 commit 1a9e63e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -115,23 +115,23 @@ header_text "running golangci-lint"
115115

116116
golangci-lint run --disable-all \
117117
--enable=misspell \
118-
--enable=structcheck \
119118
--enable=golint \
120119
--enable=deadcode \
121120
--enable=goimports \
122121
--enable=errcheck \
123122
--enable=varcheck \
124-
--enable=goconst \
125123
--enable=unparam \
126124
--enable=ineffassign \
127125
--enable=nakedret \
128-
--enable=interfacer \
129126
--enable=misspell \
130127
--enable=gocyclo \
131128
--enable=gosec \
132-
--skip-dirs=parse \
133129
./pkg/... ./cmd/...
134130

131+
# --enable=structcheck \ # doesn't understand embedded structs
132+
# --enable=goconst \ # complains about constants that shouldn't be constants
133+
# --enable=interfacer \ # just kinda strange, deprecated, has bad suggestions that defeat self-documenting code
134+
135135
header_text "running go test"
136136

137137
go test -mod=vendor ./pkg/... ./cmd/... -parallel 4

0 commit comments

Comments
 (0)