Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle External API Types for Webhooks #4201

Closed
camilamacedo86 opened this issue Oct 1, 2024 · 0 comments
Closed

Handle External API Types for Webhooks #4201

camilamacedo86 opened this issue Oct 1, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

Currently, Kubebuilder has support for handling external API types when scaffolding controllers, as addressed in PR #4171. However, there is no equivalent support for webhooks when dealing with external API types.

To maintain consistency, we need to ensure that external API types are properly handled for webhooks as well, similar to how core types are managed. For reference, see the discussion around handling core types: Issue #2141.

What needs to happen:

  • Add support for external API types in webhooks, similar to the approach implemented for controllers.
  • Ensure that webhook scaffolding correctly identifies and handles external API types during the generation process.

Acceptance Criteria:

  • External API types should be supported when scaffolding webhooks.
  • Tests should cover cases where external API types are used in the webhook scaffolding process.
  • We must have en example added to the testdata samples for single and multigroup layout.

Extra Labels

No response

@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant