Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TAS: reduce friction by defaulting the PodSet annotations #3754

Open
3 tasks
mimowo opened this issue Dec 6, 2024 · 2 comments
Open
3 tasks

TAS: reduce friction by defaulting the PodSet annotations #3754

mimowo opened this issue Dec 6, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2024

What would you like to be added:

Allow scheduling workloads without TAS annotations (kueue.x-k8s.io/podset-required-topology or kueue.x-k8s.io/podset-preferred-topology) on every PodSet.

The idea is to default the annotations, but we need to decide where is the configuration.

Why is this needed:

Currently, users of TAS need to set annotations on every PodTemplate. While this gives control, it also creates friction and room for error, because users may forget to set the annotation. Also, most users want to use the "preferred" mode, and they don't need to control the topology level.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc (KEP update)
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Dec 6, 2024

cc @mwielgus @mwysokin @tenzen-y

@mimowo mimowo changed the title TAS: reduce friction for setting the PodSet annotations TAS: reduce friction by defaulting the PodSet annotations Dec 6, 2024
@mwysokin
Copy link
Contributor

Maybe ResourceFlavor? Since it's usually related to the machine type and it can benefit only some of the machine types? Maybe the default could be kubernetes.io/hostname since it seems to give the best compact placement?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants