CRD support for variables + images - broken

[rosscdh]

I setup "variables"
When using kind: Deployment
the variables are substituted

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: helloworld
  name: helloworld
spec:
  replicas: 2
  selector:
    matchLabels:
      app: helloworld
  strategy:
    blueGreen:
      activeService: helloworld-svc-active
      autoPromotionEnabled: false
      previewService: helloworld-svc-preview
  template:
    metadata:
      labels:
        app: helloworld
    spec:
      containers:
      - env:
        - name: DEPLOY_VERSION
          value: orange
        image: someplage/hellopy
        imagePullPolicy: Always

When using a CRD kind: Rollout
the variables are not substituted

---
apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  labels:
    app: helloworld
  name: helloworld
spec:
  replicas: 2
  selector:
    matchLabels:
      app: helloworld
  strategy:
    blueGreen:
      activeService: helloworld-svc-active
      autoPromotionEnabled: false
      previewService: helloworld-svc-preview
  template:
    metadata:
      labels:
        app: helloworld
    spec:
      containers:
      - env:
        - name: DEPLOY_VERSION
          value: $(DEPLOYMENT_COLOUR)

Expectation, variables get substituted regardless of kind

[jbrette]

@rosscdh I do believe that you are missing a varReference configuration:

varReference:
- path: spec/template/spec/containers[]/env[]/value
  kind: Rollout

Have a look at the files used to reproduce the issue here. The output folder is here

An example for a CRD is in doc

The reason is works out of the box for deployment is here

The output with such a field is:

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  labels:
    app: helloworld
  name: helloworld
spec:
  replicas: 2
  selector:
    matchLabels:
      app: helloworld
  strategy:
    blueGreen:
      activeService: helloworld-svc-active
      autoPromotionEnabled: false
      previewService: helloworld-svc-preview
  template:
    metadata:
      labels:
        app: helloworld
    spec:
      containers:
      - env:
        - name: DEPLOY_VERSION
          value: orange

Also we are trying to get feedback on the usability of another PR: Automatic Creation of 'vars:' and 'varReferences:' sections

Have a look at the strategy field in the rollout input and rendered files. See variable $(Values.file1.spec.blueGreen) is automatically replaced without the need for vars: nor varReferences:

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  labels:
    app: helloworld
  name: helloworld
spec:
  replicas: 2
  selector:
    matchLabels:
      app: helloworld
  strategy:
    blueGreen: $(Values.file1.spec.blueGreen)
  template:
    metadata:
      labels:
        app: helloworld
    spec:
      containers:
      - env:
        - name: DEPLOY_VERSION
          value: $(DEPLOYMENT_COLOR)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[rosscdh]

Thanks! :)