Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add request handlers to v2 implementation #137

Open
randomvariable opened this issue Sep 30, 2020 · 8 comments
Open

Add request handlers to v2 implementation #137

randomvariable opened this issue Sep 30, 2020 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@randomvariable
Copy link
Member

randomvariable commented Sep 30, 2020

What would you like to be added:
Follow up from #131, add AWS request handlers to do the following:

  • Add metrics
  • Add rate limiting

@M00nF1sh , do you think it's worth re-implementing what's done in in https://github.com/aws/aws-app-mesh-controller-for-k8s/tree/master/pkg/aws for the above?

FWIW, I used the same metric formats in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/metrics/metrics.go, so would be worth standardising.

Why is this needed:

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2020
@M00nF1sh
Copy link
Contributor

@randomvariable Thanks for reaching out. I think we can keep same format(i'm open to new metrics if applicable) :D

@randomvariable
Copy link
Member Author

@M00nF1sh Are we ok to copy the throttle package over to this repo and cluster-api?

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Oct 1, 2020

@randomvariable of course. but i do think the throttle package needs some enhancements.
e.g. it should use endpointID instead of serviceName when throttling. since some service's serviceName have space within it.

@randomvariable
Copy link
Member Author

/assign

@nckturner
Copy link
Contributor

nckturner commented Oct 8, 2020

I spoke with @jaypipes and he is going to create a repository under the aws organization to put the throttle package and any other widely shared utils. @M00nF1sh WDYT about that?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2021
@randomvariable
Copy link
Member Author

@jaypipes has any progress been made on creating the repo to include importable limiters?

@randomvariable
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants