-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add request handlers to v2 implementation #137
Comments
@randomvariable Thanks for reaching out. I think we can keep same format(i'm open to new metrics if applicable) :D |
@M00nF1sh Are we ok to copy the throttle package over to this repo and cluster-api? |
@randomvariable of course. but i do think the throttle package needs some enhancements. |
/assign |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@jaypipes has any progress been made on creating the repo to include importable limiters? |
/lifecycle frozen |
What would you like to be added:
Follow up from #131, add AWS request handlers to do the following:
@M00nF1sh , do you think it's worth re-implementing what's done in in https://github.com/aws/aws-app-mesh-controller-for-k8s/tree/master/pkg/aws for the above?
FWIW, I used the same metric formats in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/metrics/metrics.go, so would be worth standardising.
Why is this needed:
/kind feature
The text was updated successfully, but these errors were encountered: