From 986c61d15e12abf23515caec5e916a3fd53203c7 Mon Sep 17 00:00:00 2001 From: josedonizetti Date: Thu, 30 May 2019 14:56:46 -0300 Subject: [PATCH 1/9] Fix kvm gpu log --- pkg/drivers/kvm/gpu.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/drivers/kvm/gpu.go b/pkg/drivers/kvm/gpu.go index 39b455596137..6c9043de5ba7 100644 --- a/pkg/drivers/kvm/gpu.go +++ b/pkg/drivers/kvm/gpu.go @@ -174,7 +174,7 @@ func isIsolated(device string) bool { iommuGroupPath := filepath.Join(sysFsPCIDevicesPath, device, "iommu_group", "devices") otherDevices, err := ioutil.ReadDir(iommuGroupPath) if err != nil { - log.Infof("Error reading %q: %v", iommuGroupPath) + log.Infof("Error reading %q: %v", iommuGroupPath, err) return false } From 079d22c950f96984803309356c98d5705a81dced Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Thu, 30 May 2019 12:43:48 -0700 Subject: [PATCH 2/9] clean vendor on make clean --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 84aec214d1c0..8456cd2f43d8 100755 --- a/Makefile +++ b/Makefile @@ -209,6 +209,7 @@ checksum: clean: rm -rf $(BUILD_DIR) rm -f pkg/minikube/assets/assets.go + rm -rf ./vendor .PHONY: gendocs gendocs: out/docs/minikube.md From 529b5aa389812b9230e7dc2b4816f3f640fb9d78 Mon Sep 17 00:00:00 2001 From: Benn Linger Date: Thu, 30 May 2019 16:21:44 -0400 Subject: [PATCH 3/9] Fixed addon-manager failing with non-default --apiserver-port --- pkg/minikube/bootstrapper/certs.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/bootstrapper/certs.go b/pkg/minikube/bootstrapper/certs.go index bde242f453a1..2fb234a22204 100644 --- a/pkg/minikube/bootstrapper/certs.go +++ b/pkg/minikube/bootstrapper/certs.go @@ -17,6 +17,7 @@ limitations under the License. package bootstrapper import ( + "fmt" "net" "path" "path/filepath" @@ -66,7 +67,7 @@ func SetupCerts(cmd CommandRunner, k8s config.KubernetesConfig) error { kubeCfgSetup := &util.KubeConfigSetup{ ClusterName: k8s.NodeName, - ClusterServerAddress: "https://localhost:8443", + ClusterServerAddress: fmt.Sprintf("https://localhost:%d", k8s.NodePort), ClientCertificate: path.Join(util.DefaultCertPath, "apiserver.crt"), ClientKey: path.Join(util.DefaultCertPath, "apiserver.key"), CertificateAuthority: path.Join(util.DefaultCertPath, "ca.crt"), From 8c186e851e9e1fd5c0cdd8ad2fe7cd0f9f8751c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Str=C3=B6mberg?= Date: Thu, 30 May 2019 15:54:22 -0700 Subject: [PATCH 4/9] Add survey link --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 996df74da928..00425c16a99b 100644 --- a/README.md +++ b/README.md @@ -21,13 +21,15 @@ minikube's [primary goals](https://github.com/kubernetes/minikube/blob/master/do ## News +**Have you used #minikube recently?** Please fill out our [fast 5-question survey](https://forms.gle/Gg3hG5ZySw8c1C24A) so that we can learn how and why you are using minikube, and what improvements we should make. Thank you! :man-with-bunny-ears-partying: + * 2019-05-21 - v1.1.0 released! [[download](https://github.com/kubernetes/minikube/releases/tag/v1.1.0)] [[release notes](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-110---2019-05-21)] * 2019-04-29 - v1.0.1 released! [[download](https://github.com/kubernetes/minikube/releases/tag/v1.0.1)] [[release notes](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-101---2019-04-29)] * 2019-03-27 - v1.0.0 released! [[download](https://github.com/kubernetes/minikube/releases/tag/v1.0.0)] [[release notes](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1000---2019-03-27)] ## Features -minikube runs the official stable release of Kubernetes, with support for standard Kubernetes features like: +minikube runs the latest stable release of Kubernetes, with support for standard Kubernetes features like: * [LoadBalancer](https://github.com/kubernetes/minikube/blob/master/docs/tunnel.md) - using `minikube tunnel` * Multi-cluster - using `minikube start -p ` From f8fa0748c5a474bc2a62816ce318a6740fc00fea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Str=C3=B6mberg?= Date: Thu, 30 May 2019 15:58:21 -0700 Subject: [PATCH 5/9] Fix emoji. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 00425c16a99b..d4f4d36c55fc 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ minikube's [primary goals](https://github.com/kubernetes/minikube/blob/master/do ## News -**Have you used #minikube recently?** Please fill out our [fast 5-question survey](https://forms.gle/Gg3hG5ZySw8c1C24A) so that we can learn how and why you are using minikube, and what improvements we should make. Thank you! :man-with-bunny-ears-partying: +:mega: **Please fill out our [fast 5-question survey](https://forms.gle/Gg3hG5ZySw8c1C24A)** so that we can learn how & why you use minikube, and what improvements we should make. Thank you! :dancers: * 2019-05-21 - v1.1.0 released! [[download](https://github.com/kubernetes/minikube/releases/tag/v1.1.0)] [[release notes](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-110---2019-05-21)] * 2019-04-29 - v1.0.1 released! [[download](https://github.com/kubernetes/minikube/releases/tag/v1.0.1)] [[release notes](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-101---2019-04-29)] From 4e3b9c8907c4a7c31bebf356836272ed10005fa3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Str=C3=B6mberg?= Date: Thu, 30 May 2019 16:04:46 -0700 Subject: [PATCH 6/9] Add issue links for most open items in the roadmap --- docs/contributors/roadmap.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/contributors/roadmap.md b/docs/contributors/roadmap.md index 90c1ec9a73d6..b7a6f96f2f50 100644 --- a/docs/contributors/roadmap.md +++ b/docs/contributors/roadmap.md @@ -6,41 +6,41 @@ Please send a PR to suggest any improvements to it. ## (#1) User-friendly and accessible -- [ ] Creation of a user-centric minikube website for installation & documentation -- [ ] Localized output to 5+ written languages +- [ ] Creation of a user-centric minikube website for installation & documentation [#4388](https://github.com/kubernetes/minikube/issues/4388) +- [ ] Localized output to 5+ written languages [#4186](https://github.com/kubernetes/minikube/issues/4186) [#4185](https://github.com/kubernetes/minikube/issues/4185) - [x] Make minikube usable in environments with challenging connectivity requirements -- [ ] Support lightweight deployment methods for environments where VM's are impractical +- [ ] Support lightweight deployment methods for environments where VM's are impractical [#4389](https://github.com/kubernetes/minikube/issues/4389) [#4390](https://github.com/kubernetes/minikube/issues/4390) - [x] Add offline support ## (#2) Inclusive and community-driven - [x] Increase community involvement in planning and decision making -- [ ] Make the continuous integration and release infrastructure publicly available +- [ ] Make the continuous integration and release infrastructure publicly available [#3256](https://github.com/kubernetes/minikube/issues/4390) - [x] Double the number of active maintainers ## (#3) Cross-platform -- [ ] Simplified installation process across all supported platforms -- [ ] Users should never need to separately install supporting binaries +- [ ] Users should never need to separately install supporting binaries [#3975](https://github.com/kubernetes/minikube/issues/3975) [#4391](https://github.com/kubernetes/minikube/issues/4391) +- [ ] Simplified installation process across all supported platforms ## (#4) Support all Kubernetes features -- [ ] Add multi-node support +- [ ] Add multi-node support [#94](https://github.com/kubernetes/minikube/issues/94) ## (#5) High-fidelity -- [ ] Reduce guest VM overhead by 50% +- [ ] Reduce guest VM overhead by 50% [#3207](https://github.com/kubernetes/minikube/issues/3207) - [x] Disable swap in the guest VM ## (#6) Compatible with all supported Kubernetes releases - [x] Continuous Integration testing across all supported Kubernetes releases -- [ ] Automatic PR generation for updating the default Kubernetes release minikube uses +- [ ] Automatic PR generation for updating the default Kubernetes release minikube uses [#4392](https://github.com/kubernetes/minikube/issues/4392) ## (#7) Support for all Kubernetes-friendly container runtimes - [x] Run all integration tests across all supported container runtimes -- [ ] Support for Kata Containers (help wanted!) +- [ ] Support for Kata Containers [#4347](https://github.com/kubernetes/minikube/issues/4347) ## (#8) Stable and easy to debug From d40751ff38750fd6c2c88073a77a08a271644a67 Mon Sep 17 00:00:00 2001 From: fenglixa Date: Fri, 31 May 2019 21:36:49 +0800 Subject: [PATCH 7/9] Fix nonexistent profile --- cmd/minikube/cmd/dashboard.go | 36 ++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/cmd/minikube/cmd/dashboard.go b/cmd/minikube/cmd/dashboard.go index 200d285d03c1..f45dae902edd 100644 --- a/cmd/minikube/cmd/dashboard.go +++ b/cmd/minikube/cmd/dashboard.go @@ -26,13 +26,13 @@ import ( "regexp" "time" + "github.com/docker/machine/libmachine/mcnerror" "github.com/golang/glog" "github.com/pkg/browser" "github.com/pkg/errors" "github.com/spf13/cobra" configcmd "k8s.io/minikube/cmd/minikube/cmd/config" "k8s.io/minikube/pkg/minikube/cluster" - "k8s.io/minikube/pkg/minikube/config" pkg_config "k8s.io/minikube/pkg/minikube/config" "k8s.io/minikube/pkg/minikube/console" "k8s.io/minikube/pkg/minikube/exit" @@ -59,15 +59,7 @@ var dashboardCmd = &cobra.Command{ if err != nil && !os.IsNotExist(err) { console.ErrLn("Error loading profile config: %v", err) } - err = proxy.ExcludeIP(cc.KubernetesConfig.NodeIP) // to be used for http get calls - if err != nil { - glog.Errorf("Error excluding IP from proxy: %s", err) - } - kubectl, err := exec.LookPath("kubectl") - if err != nil { - exit.WithCode(exit.NoInput, "kubectl not found in PATH, but is required for the dashboard. Installation guide: https://kubernetes.io/docs/tasks/tools/install-kubectl/") - } api, err := machine.NewAPIClient() defer func() { err := api.Close() @@ -79,6 +71,28 @@ var dashboardCmd = &cobra.Command{ if err != nil { exit.WithError("Error getting client", err) } + + _, err = api.Load(pkg_config.GetMachineName()) + if err != nil { + switch err := errors.Cause(err).(type) { + case mcnerror.ErrHostDoesNotExist: + console.OutStyle(console.Meh, "%q cluster does not exist", pkg_config.GetMachineName()) + os.Exit(0) + default: + exit.WithError("Error getting cluster", err) + } + } + + err = proxy.ExcludeIP(cc.KubernetesConfig.NodeIP) // to be used for http get calls + if err != nil { + glog.Errorf("Error excluding IP from proxy: %s", err) + } + + kubectl, err := exec.LookPath("kubectl") + if err != nil { + exit.WithCode(exit.NoInput, "kubectl not found in PATH, but is required for the dashboard. Installation guide: https://kubernetes.io/docs/tasks/tools/install-kubectl/") + } + cluster.EnsureMinikubeRunningOrExit(api, 1) // Send status messages to stderr for folks re-using this output. @@ -127,9 +141,9 @@ var dashboardCmd = &cobra.Command{ // kubectlProxy runs "kubectl proxy", returning host:port func kubectlProxy(path string) (*exec.Cmd, string, error) { // port=0 picks a random system port - // config.GetMachineName() respects the -p (profile) flag + // pkg_config.GetMachineName() respects the -p (profile) flag - cmd := exec.Command(path, "--context", config.GetMachineName(), "proxy", "--port=0") + cmd := exec.Command(path, "--context", pkg_config.GetMachineName(), "proxy", "--port=0") stdoutPipe, err := cmd.StdoutPipe() if err != nil { From f596947a8b692a62a65af1e7217f678887d832ad Mon Sep 17 00:00:00 2001 From: josedonizetti Date: Fri, 31 May 2019 13:56:22 -0300 Subject: [PATCH 8/9] Fix kvm trobleshoot documentation --- docs/drivers.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/drivers.md b/docs/drivers.md index 9200204e65a4..14a63bf8a0aa 100644 --- a/docs/drivers.md +++ b/docs/drivers.md @@ -92,6 +92,7 @@ In case the default network doesn't exist you can define it. ```shell curl https://raw.githubusercontent.com/libvirt/libvirt/master/src/network/default.xml > kvm-default.xml virsh net-define kvm-default.xml +virsh net-start default ``` ## Hyperkit driver From bbc679be0e1694289e33744b643a861fba5bd1d2 Mon Sep 17 00:00:00 2001 From: fenglixa Date: Sun, 2 Jun 2019 13:26:42 +0800 Subject: [PATCH 9/9] modify to exit.Unavailable and align the code --- cmd/minikube/cmd/dashboard.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cmd/minikube/cmd/dashboard.go b/cmd/minikube/cmd/dashboard.go index f45dae902edd..fafe742fb0ab 100644 --- a/cmd/minikube/cmd/dashboard.go +++ b/cmd/minikube/cmd/dashboard.go @@ -72,12 +72,11 @@ var dashboardCmd = &cobra.Command{ exit.WithError("Error getting client", err) } - _, err = api.Load(pkg_config.GetMachineName()) - if err != nil { + if _, err = api.Load(pkg_config.GetMachineName()); err != nil { switch err := errors.Cause(err).(type) { case mcnerror.ErrHostDoesNotExist: console.OutStyle(console.Meh, "%q cluster does not exist", pkg_config.GetMachineName()) - os.Exit(0) + os.Exit(exit.Unavailable) default: exit.WithError("Error getting cluster", err) }