Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(config): improve emit skipped error message and ensure outDir always TS_JEST_OUT_DIR #2357

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 13, 2021

Summary

  • Stuffs from outDir can cause LanguageService not emit any codes and run into emit skipped mode therefore setting internally outDir to TS_JEST_OUT_DIR always.

  • Improve emit skipped error message

Closes #2350

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl marked this pull request as ready for review February 13, 2021 22:42
@ahnpnl ahnpnl merged commit f2808bb into kulshekhar:26.5.2 Feb 13, 2021
@ahnpnl ahnpnl deleted the set-outdir-undefined branch February 13, 2021 22:43
This was referenced Mar 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant