-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Trim FES2022 Loading Areas #559
Comments
hey @phillipjws , I think it's a great feature!!! I have noticed the RAM usage too with FES2022. It was not the case with FES2014 where it wouldn't load everything in memory. |
Awesome, I will work on a PR throughout this week @kvos. I will likely do a little bit of refactoring from the original script I posted to make it better match with the rest of the toolkit. I'm not too sure that clipping per AOI is the best methodology, as I'm not too sure if this will save time/resources apart from when the same AOI is being rerun. For my purposes I have been focusing initially on the western coast of Canada, and so have been using a region that contains all of Canada, which has significantly reduced the time needed. As long as it contains all of the AOIs the user may be interested in, I think this is a good approach, although I'm keen to anything, let me know your thoughts. Can write some test cases on an AOI scale to see how much time is saved aswell. Let me know whether I should put the new code in SDS_slope.py (due to it being related to tidal modelling) or if it would better fit under SDS_tools.py. Thanks @kvos ! |
ok makes sense for a larger region. Just make sure not to overwrite the original files, so the user always has the choice to go for global. yes good suggestion, it can go in SDS_slope.py |
Sounds good, I will likely create a new subfolder in the root of the package to hold these files, and will create a new yaml in the same spot. This will be easy to automate, as we will already know where all of the cdf files are. Thanks |
Hello,
I have been using CoastSat for quite some time now, with a main bottleneck in my automation being the loading of the FES2022 config files. I was digging around to see if there was any optimizations to reduce RAM usage in this part of the toolkit, and I found that in CoastSeg they trim the area, allowing the user to only load what they need. I tried to write a short script to automate this based on an input polygon, and this was my outcome:
This might only be useful on a larger scale, as I'm not too sure how useful this would be to trim individually for each AOI. You get the same results when using these files as the original one, with a fraction of the resource usage.
Something like this being incorporated into the workflow of CoastSat would be very helpful, although may be worth investigating to see if the user should be trimming for each AOI or a bigger polygon containing all of their specific AOIs like I have.
Let me know your thoughts on incorporating this as a feature, as load time and resource usage are greatly reduced through this method.
The text was updated successfully, but these errors were encountered: