Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cache-control global options not working correctly #239

Open
springyboy opened this issue May 24, 2021 · 2 comments
Open

cache-control global options not working correctly #239

springyboy opened this issue May 24, 2021 · 2 comments

Comments

@springyboy
Copy link

Hi,

Is there a bug in the newly implement global options for cache-control?

It looks like the method sendCachedResponse (apicache.js 258) does not check the global options for the header cache-control and writes a new cache-control header with a reduced max-age. This causes the browser to cache the response from the api even if the global option cache-control is specified as no-cache.

I could be wrong.

@Izook
Copy link

Izook commented May 24, 2021

You might want to look at #205. It looks like this package is losing support but there's a fork of this package with this improvement.

@ravinatesanatr
Copy link

This seems to be a defect. It's happening for us too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants