Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

app.tls_cert_file and app.tls_key_file are incorrectly documented #999

Closed
3 tasks
brennanjl opened this issue Sep 19, 2024 · 2 comments · Fixed by #1013
Closed
3 tasks

app.tls_cert_file and app.tls_key_file are incorrectly documented #999

brennanjl opened this issue Sep 19, 2024 · 2 comments · Fixed by #1013
Assignees
Milestone

Comments

@brennanjl
Copy link
Collaborator

The app.tls_cert_file and app.tls_key_file configs are not correctly documented, and should be renamed.

Previously, these configs allowed users to configure TLS for all of the RPCs provided by Kwil. However, when we moved the user service to JSON RPC, we removed the ability to configure TLS, since most users should just use nginx anyways. Now, the TLS configs only apply to the admin service and to comet BFT's RPC (which I am not sure why we ever had it do that in the first place).

Therefore, there are 3 changes we need to make:

  • rename the configs to be app.admin_tls_cert_file and app.admin_tls_key_file
  • remove the ability for these to be used to configure CometBFT's RPC
  • update the documentation to make it clear these are only for admin
@brennanjl brennanjl added this to the v0.9 milestone Sep 19, 2024
@jchappelow jchappelow self-assigned this Sep 23, 2024
@jchappelow
Copy link
Member

Doing this. Assuming you don't have this already done @brennanjl ?

@brennanjl
Copy link
Collaborator Author

I have not done this yet. Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants