Skip to content

Commit 1158160

Browse files
committed
fix(testscheduler): do not expose advance_ interface
1 parent 2f4540f commit 1158160

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/index.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import { Observable } from 'rxjs/Observable';
2+
import { ColdObservable } from 'rxjs/testing/ColdObservable';
3+
import { HotObservable } from 'rxjs/testing/HotObservable';
24
import { SubscriptionLog } from 'rxjs/testing/SubscriptionLog';
35
import { parseObservableMarble } from './marbles/parseObservableMarble';
46
import { parseSubscriptionMarble } from './marbles/parseSubscriptionMarble';
@@ -8,6 +10,8 @@ import { TestScheduler } from './scheduler/TestScheduler';
810
//workaround TS4029 by explicitly import types and avoid unused import error
911
(() => Observable.toString())();
1012
(() => SubscriptionLog.toString())();
13+
(() => ColdObservable.toString())();
14+
(() => HotObservable.toString())();
1115

1216
const rxSandbox = {
1317
create: (autoFlush: boolean = false, frameTimeFactor: number = 1) => {
@@ -17,8 +21,6 @@ const rxSandbox = {
1721
hot: scheduler.createHotObservable.bind(scheduler) as typeof scheduler.createHotObservable,
1822
cold: scheduler.createColdObservable.bind(scheduler) as typeof scheduler.createColdObservable,
1923
flush: scheduler.flush.bind(scheduler) as typeof scheduler.flush,
20-
advanceBy: scheduler.advanceBy.bind(scheduler) as typeof scheduler.advanceBy,
21-
advanceTo: scheduler.advanceTo.bind(scheduler) as typeof scheduler.advanceTo,
2224
getMarbles: scheduler.getMarbles.bind(scheduler) as typeof scheduler.getMarbles,
2325
e: <T = string>(marble: string, value?: { [key: string]: T } | null, error?: any) =>
2426
parseObservableMarble(marble, value, error, true, frameTimeFactor),

src/scheduler/TestScheduler.ts

-8
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,6 @@ class TestScheduler extends VirtualTimeScheduler {
6565
return observableMetadata;
6666
}
6767

68-
public advanceBy(_frameTime: number): void {
69-
throw new Error('not implemented');
70-
}
71-
72-
public advanceTo(_frameTime: number): void {
73-
throw new Error('not implemented');
74-
}
75-
7668
public createColdObservable<T = string>(marble: string, value?: { [key: string]: T }, error?: any): ColdObservable<T>;
7769
public createColdObservable<T = string>(message: Array<TestMessage<T>>): ColdObservable<T>;
7870
public createColdObservable<T = string>(...args: Array<any>): ColdObservable<T> {

0 commit comments

Comments
 (0)