feat(observablemarbleassert): input validation

Author: kwonoj

spec/assert/marbleAssert-spec.ts

@@ -8,12 +8,58 @@ describe('marbleAssert', () => {
   });
 
   describe('TestMessage', () => {
-    //noop
+    it(`should throw if expected value isn't array`, () => {
+      expect(() => marbleAssert([]).to.equal(new SubscriptionLog(0) as any)).to.throw();
+    });
+
+    it('should pass hot observables', () => {
+      //noop
+    });
+
+    it('should pass cold observable', () => {
+      //noop
+    });
+
+    it('should pass hot and cold observables', () => {
+      //noop
+    });
+
+    it('should pass observable with noop', () => {
+      //noop
+    });
+
+    it('should pass observable with groups', () => {
+      //noop
+    });
+
+    it('should pass observable with expand', () => {
+      //noop
+    });
+
+    it('should pass observable with complete', () => {
+      //noop
+    });
+
+    it('should pass observable with error', () => {
+      //noop
+    });
+
+    it('should pass observable with non completion', () => {
+      //noop
+    });
+
+    it('should pass hot observable with subscription, emit before sub', () => {
+      //noop
+    });
+
+    it('should pass hot observable with subscription, without emit before sub', () => {
+      //noop
+    });
   });
 
   describe('SubscriptionLog', () => {
     it(`should throw if expected value isn't subscription log`, () => {
-      expect(() => marbleAssert(new SubscriptionLog(0, 0)).to.equal(1 as any)).to.throw();
+      expect(() => marbleAssert(new SubscriptionLog(0, 0)).to.equal([] as any)).to.throw();
     });
 
     it('should pass if subscription matches', () => {
@@ -47,28 +93,28 @@ describe('marbleAssert', () => {
       expect(() => marbleAssert(source).to.equal(expected)).to.throw();
     });
 
-    it('should pass if subscription with unsubscription unmatches', () => {
+    it('should assert if subscription with unsubscription unmatches', () => {
       const source = new SubscriptionLog(10, 45);
       const expected = new SubscriptionLog(12, 46);
 
       expect(() => marbleAssert(source).to.equal(expected)).to.throw();
     });
 
-    it('should pass if subscription unmatches with unsubscription', () => {
+    it('should assert if subscription unmatches with unsubscription', () => {
       const source = new SubscriptionLog(10, 45);
       const expected = new SubscriptionLog(12, 45);
 
       expect(() => marbleAssert(source).to.equal(expected)).to.throw();
     });
 
-    it('should pass if unsubscription with subscription unmatches', () => {
+    it('should assert if unsubscription with subscription unmatches', () => {
       const source = new SubscriptionLog(10, 45);
       const expected = new SubscriptionLog(10, 46);
 
       expect(() => marbleAssert(source).to.equal(expected)).to.throw();
     });
 
-    it('should pass if unsubscription unmatches', () => {
+    it('should assert if unsubscription unmatches', () => {
       const source = new SubscriptionLog(Number.POSITIVE_INFINITY, 20);
       const expected = new SubscriptionLog(Number.POSITIVE_INFINITY, 30);
 

src/assert/marbleAssert.ts

@@ -1,10 +1,22 @@
 import { matcherHint, printExpected, printReceived } from 'jest-matcher-utils';
+//tslint:disable-next-line:no-require-imports
+import isEqualWith = require('lodash.isequalwith');
 import { SubscriptionLog } from 'rxjs/testing/SubscriptionLog';
 import { TestMessage } from '../message/TestMessage';
+import { constructObservableMarble } from './constructObservableMarble';
 import { constructSubscriptionMarble } from './constructSubscriptionMarble';
 
-const observableMarbleAssert = (_source: Array<TestMessage>) => (_expected: Array<TestMessage>) => {
-  throw new Error('not impl');
+const observableMarbleAssert = (source: Array<TestMessage>) => (expected: Array<TestMessage>) => {
+  if (!Array.isArray(expected)) {
+    throw new Error('Expected value is not array');
+  }
+
+  const sourceMarble = constructObservableMarble(source);
+  const expectedMarble = constructObservableMarble(expected);
+
+  if (!isEqualWith(sourceMarble, expectedMarble)) {
+    throw new Error('unmatch');
+  }
 };
 
 const subscriptionMarbleAssert = (source: SubscriptionLog) => (expected: SubscriptionLog) => {