Minor bug fixing

'this' is the jQuery object inside fn, no need to wrap it another $ object use the constant for close event name
kylefox · Feb 18, 2012 · 2865c27 · 2865c27
1 parent 148d228
commit 2865c27
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/jquery.modal.js b/jquery.modal.js
@@ -8,7 +8,7 @@
 
   $.fn.modal = function(options) {
 
-    var $elm = $(this);
+    var $elm = this;
 
     // If this is a link, bind to its click event.
     if($elm.attr('href')) {
@@ -109,7 +109,7 @@
         $('<div/>')
           .html(html)
           .appendTo('body')
-          .on('modal:close', function(event, modal) { modal.elm.remove(); })
+          .on($.fn.modal.CLOSE, function(event, modal) { modal.elm.remove(); })
           .modal();
       });
     }