Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

modbusrtu/dev extras make pyserial overwrite pyserial-labgrid #1245

Open
Bastian-Krause opened this issue Jul 21, 2023 · 1 comment · May be fixed by labgrid-project/pyserial#2
Open

modbusrtu/dev extras make pyserial overwrite pyserial-labgrid #1245

Bastian-Krause opened this issue Jul 21, 2023 · 1 comment · May be fixed by labgrid-project/pyserial#2
Labels

Comments

@Bastian-Krause
Copy link
Member

Bastian-Krause commented Jul 21, 2023

Having labgrid installed without extras:

$ pip freeze | grep pyserial
pyserial-labgrid==3.5.0.2
$ python -c 'import serial; print(serial.VERSION)'
3.5.0.2

With modbusrtu or dev extra (pulling in minimalmodbus, which depends on pyserial):

$ pip freeze | grep pyserial
pyserial==3.5
pyserial-labgrid==3.5.0.2
$ python -c 'import serial; print(serial.VERSION)'
3.5

This means pyserial effectively overwrites pyserial-labgrid.

I don't know if pyserial always overwrites pyserial-labgrid, it probably depends on pip's dependency resolving strategy.

@Bastian-Krause Bastian-Krause changed the title modbusrtu/dev extras makes pyserial overwrite pyserial-labgrid modbusrtu/dev extras make pyserial overwrite pyserial-labgrid Jul 21, 2023
@jluebbe
Copy link
Member

jluebbe commented Jul 21, 2023

To avoid this, we might need to rename the package in our pyserial fork, so that the import explicitly uses it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants