Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

script migrate vfolder structure #319

Merged
merged 6 commits into from
Sep 4, 2020
Merged

script migrate vfolder structure #319

merged 6 commits into from
Sep 4, 2020

Conversation

leksikov
Copy link
Contributor

Script to migrate the vfolder vroot/local structure.

Example usage: python migrate-vfolder-structure.py /Users/name/vroot/local/ /Users/name/vroot/vfs/

This script will automatically create new folder structure and move files.

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #319 into master will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   49.19%   49.77%   +0.57%     
==========================================
  Files          46       46              
  Lines        6899     7090     +191     
==========================================
+ Hits         3394     3529     +135     
- Misses       3505     3561      +56     
Impacted Files Coverage Δ
src/ai/backend/manager/plugin/error_monitor.py 38.59% <0.00%> (-11.41%) ⬇️
src/ai/backend/manager/cli/__main__.py 82.79% <0.00%> (-6.86%) ⬇️
src/ai/backend/gateway/server.py 62.60% <0.00%> (+4.08%) ⬆️
src/ai/backend/gateway/config.py 84.52% <0.00%> (+4.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b737e2...dd5cefd. Read the comment docs.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pathlib and / operator to make it portable.
And also add the news fragment under changes directory.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the comments.

@leksikov leksikov marked this pull request as ready for review September 3, 2020 01:26
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good now.
Please do the followings for finishing up:

  • Add the news fragment as a single-sentence Markdown text file, changes/319.feature.
  • Please fix up mypy error.
  • Update our internal KB1040 to mention this script.

@leksikov
Copy link
Contributor Author

leksikov commented Sep 3, 2020

Wiki KB1040 updated.
319.feature created.

I don't understand the mypy error message which happened on pull request.
Actually I checked the locally file with mypy and there were no issues.
Besides, this is a standalone executable script file with no dependencies.

@achimnol
Copy link
Member

achimnol commented Sep 4, 2020

Ok, the mypy error looks like a issue for #321 and follow-up commits. I will merge this PR.

@achimnol achimnol merged commit 53b5a12 into master Sep 4, 2020
@achimnol achimnol deleted the manager-tmp branch September 4, 2020 01:51
@achimnol achimnol added this to the 20.09 milestone Oct 5, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants