-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 49.19% 49.77% +0.57%
==========================================
Files 46 46
Lines 6899 7090 +191
==========================================
+ Hits 3394 3529 +135
- Misses 3505 3561 +56
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use pathlib
and /
operator to make it portable.
And also add the news fragment under changes
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except the comments.
Co-authored-by: Joongi Kim <joongi@lablup.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good now.
Please do the followings for finishing up:
- Add the news fragment as a single-sentence Markdown text file,
changes/319.feature
. - Please fix up mypy error.
- Update our internal KB1040 to mention this script.
Wiki KB1040 updated. I don't understand the mypy error message which happened on pull request. |
Ok, the mypy error looks like a issue for #321 and follow-up commits. I will merge this PR. |
Script to migrate the vfolder vroot/local structure.
Example usage: python migrate-vfolder-structure.py /Users/name/vroot/local/ /Users/name/vroot/vfs/
This script will automatically create new folder structure and move files.