-
Notifications
You must be signed in to change notification settings - Fork 19
Add support for dotfiles of domains and groups #329
Conversation
…ature/add-support-shell-profiles
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 48.97% 48.85% -0.13%
==========================================
Files 47 47
Lines 6995 7058 +63
==========================================
+ Hits 3426 3448 +22
- Misses 3569 3610 +41
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments mostly on authorizations.
And, I am worried about what will happen when the name of a dotfile collides with the name of a virtual folder. For example, let's say a superadmin created a dotfile named .test
, which will be mounted at /home/work/.test
inside a session container. And there is a chance that some users have a virtual folder named .test
, which will be auto-mounted. The user tries to launch a session. I'm not sure since I didn't test, but probably the session will not be launched due to naming conflict.
This is not very serious for user's dotfiles since the problem will arise only for that user. But, for domain and group dotfiles, the problem will affect many domains' and/or groups' users, if admins are careless with the dotfile naming.
Currently, I don't have a clear idea to prevent this problem. Let's discuss further with others.
LGTM. Please merge the master branch into this one, and resolve conflicting file(s). Also, try to fix broken tests if possible. |
…ature/add-support-shell-profiles
domains
andgroups
.Solving issue lablup/backend.ai#210.