This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: A race condition that corrupts the kernel status during kernel creation #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reation * Handling of kernel_preparing, kernel_creating, kernel_started events are asynchronous to recording of kernel creation results upon RPC return, and this has caused rare race conditions that make successfully started kernels to become "PREPARING" forever.
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 49.26% 49.17% -0.10%
==========================================
Files 51 51
Lines 7591 7605 +14
==========================================
Hits 3740 3740
- Misses 3851 3865 +14
Continue to review full report at Codecov.
|
achimnol
added a commit
that referenced
this pull request
Dec 20, 2020
) * Apply the same event-based sync to fix race condition for kernel status update as in #368
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.