Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: remove b-prefix in background task events function #394

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

lizable
Copy link
Collaborator

@lizable lizable commented Feb 4, 2021

This PR removes b-prefix in sending server_closed due to innate code in "aiohttp-sse".

@lizable lizable added the minor label Feb 4, 2021
@lizable lizable added this to the 20.09 milestone Feb 4, 2021
@lizable lizable self-assigned this Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #394 (2222c42) into master (02ebb0d) will decrease coverage by 1.98%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   48.56%   46.58%   -1.99%     
==========================================
  Files          51       49       -2     
  Lines        7898     7841      -57     
==========================================
- Hits         3836     3653     -183     
- Misses       4062     4188     +126     
Impacted Files Coverage Δ
src/ai/backend/gateway/events.py 50.52% <0.00%> (ø)
src/ai/backend/gateway/ratelimit.py 45.61% <0.00%> (-47.37%) ⬇️
src/ai/backend/manager/plugin/__init__.py 50.00% <0.00%> (-23.26%) ⬇️
src/ai/backend/gateway/auth.py 37.71% <0.00%> (-15.15%) ⬇️
src/ai/backend/gateway/utils.py 50.25% <0.00%> (-8.63%) ⬇️
src/ai/backend/gateway/server.py 49.18% <0.00%> (-7.66%) ⬇️
src/ai/backend/manager/models/base.py 47.86% <0.00%> (-2.57%) ⬇️
src/ai/backend/manager/plugin/exceptions.py
src/ai/backend/manager/plugin/error_monitor.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ebb0d...2222c42. Read the comment docs.

@lizable lizable marked this pull request as ready for review February 4, 2021 02:52
@lizable lizable requested a review from achimnol February 4, 2021 02:52
@achimnol achimnol merged commit bf181c4 into master Feb 16, 2021
@achimnol achimnol deleted the fix/remove-b-prefix-in-background-task-events branch February 16, 2021 02:07
achimnol pushed a commit that referenced this pull request Feb 16, 2021
Backported-From: master
Backported-To: 20.09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants