Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Internal API mismatch for our custom SQLAlchemy enum types #412

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Mar 31, 2021

Yesterday's SQLAlchemy v1.4.4 release has broken the manager, due to an internal SQLAlchemy API mismatch in _set_parent() of our EnumType and EnumValueType custom column type declaration.

@achimnol achimnol added this to the 20.09 milestone Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #412 (d928fe9) into main (3c8602a) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   48.65%   48.58%   -0.08%     
==========================================
  Files          52       52              
  Lines        8281     8279       -2     
==========================================
- Hits         4029     4022       -7     
- Misses       4252     4257       +5     
Impacted Files Coverage Δ
src/ai/backend/manager/models/base.py 53.80% <75.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875a3c6...d928fe9. Read the comment docs.

@achimnol achimnol merged commit 167bcbc into main Mar 31, 2021
@achimnol achimnol deleted the fix/sqlalchemy-custom-enum-type branch March 31, 2021 07:48
achimnol added a commit that referenced this pull request Mar 31, 2021
achimnol added a commit that referenced this pull request Mar 31, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant