This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
feat: share group virtual folder directly without invitation #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lders Two queries, for user's own vfolders and invited vfolders, were able to be merged as a single query.
…user vfolders" This reverts commit b3a5076.
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 48.86% 48.88% +0.02%
==========================================
Files 52 52
Lines 8344 8326 -18
==========================================
- Hits 4077 4070 -7
+ Misses 4267 4256 -11
Continue to review full report at Codecov.
|
User-type vfolders can be shared by invitation.
… the group vfolder belongs to
adrysn
changed the title
adrysn
changed the title
adrysn
added a commit
that referenced
this pull request
May 5, 2021
* feat: add API endpoint to share/unshare a vfolder to users * refactor: make query_accessible_vfolders shorter for listing user vfolders Two queries, for user's own vfolders and invited vfolders, were able to be merged as a single query. * Revert "refactor: make query_accessible_vfolders shorter for listing user vfolders" This reverts commit b3a5076. * fix: linting errors * refactor: shorter codes for querying accessible user-type vfolders * refactor: further shortening query accessible vfolders * feat: override group vfolder's permission if it is shared by admin * feat: prevent user-type vfolders from shared directly User-type vfolders can be shared by invitation. * Add news fragment * refactor: raise exception when some of shared user does not belong to the group vfolder belongs to * refactor: accept folder's name instead of id for client-py usability * fix: respond with shared/unshared emails * fix: correct display of group virtual folder's overriden permission * feat: list_shared_folders now return information on group folders as well * fix: do not share group vfolder to users who are not in the group Co-authored-by: Joongi Kim <joongi@lablup.com> Backported-From: main Backported-To: 21.03
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds API endpoints to share or unshare a group virtual folder to users directly with overriding permission. This is to allow specified users (usually teachers with user account) can upload data/materials to a group virtual folder while it is shared as read-only for all other group users (usually students).
Also,
query_accessible_vfoldersare refactored to account for the overriding permission of group virtual folders.Only group virtual folders are directly sharable since user-type folders can be shared by invitation. Group folders are visible to every group users without user's choice, so it does not make sense to invite a group folder.