This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
feat: Add PRE_AUTH_MIDDLEWARE hook for auth with 3rd-party headers/cookies #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 48.49% 48.68% +0.18%
==========================================
Files 52 52
Lines 8524 8543 +19
==========================================
+ Hits 4134 4159 +25
+ Misses 4390 4384 -6
Continue to review full report at Codecov.
|
Empty dict should not override template configs.
Conflicts: src/ai/backend/manager/api/auth.py tests/api/test_auth.py
adrysn
pushed a commit
that referenced
this pull request
May 15, 2021
…okies (#420) * feat: Add PRE_AUTH_MIDDLEWARE hook for auth with 3rd-party headers/cookies * fix: lint error * fix: Let hooks return just access_key for simpler implementation * fix: comment * test: Update auth test cases * test: Add event_dispatcher_ctx * test: Fix again * test: fix again * docs: Add news fragment * fix: join query was missing in querying group session templates * fix: add ID to session_template fixture * fix: further modification of session_template fixture * fix: invalid load of json object * Minor spacing fix * refactor: deliver request object to AUTHORIZE hook plugins * fix: add scaling group to session templates and fixes minor glitches * fix: drop method will drop empty dict always Empty dict should not override template configs. * fix: typo * fix: broken test case Co-authored-by: Jonghyun Park <adrysn@gmail.com> Backported-From: main Backported-To: 21.03
achimnol
added a commit
that referenced
this pull request
May 17, 2021
…okies (#420) * feat: Add PRE_AUTH_MIDDLEWARE hook for auth with 3rd-party headers/cookies * fix: lint error * fix: Let hooks return just access_key for simpler implementation * fix: comment * test: Update auth test cases * test: Add event_dispatcher_ctx * test: Fix again * test: fix again * docs: Add news fragment * fix: join query was missing in querying group session templates * fix: add ID to session_template fixture * fix: further modification of session_template fixture * fix: invalid load of json object * Minor spacing fix * refactor: deliver request object to AUTHORIZE hook plugins * fix: add scaling group to session templates and fixes minor glitches * fix: drop method will drop empty dict always Empty dict should not override template configs. * fix: typo * fix: broken test case Co-authored-by: Jonghyun Park <adrysn@gmail.com> Backported-From: main Backported-To: 20.09
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.