Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

setup: Temporarily pin pytest-asyncio to 0.14.0 due to regression in handling event loops for fixtures #423

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

achimnol
Copy link
Member

No description provided.

* pytest-asyncio 0.15 introduced a new way to close event loops
  after each test and that broke the test fixtures that uses
  internally separate event loops (e.g., `asyncio.run()`)
* The future release of pytest-asyncio will fix the issue, but
  for meanwhile we need to pin down its version.
@achimnol achimnol added this to the 20.09 milestone Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #423 (4f4b709) into main (85fe578) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   48.90%   48.90%           
=======================================
  Files          52       52           
  Lines        8322     8322           
=======================================
  Hits         4070     4070           
  Misses       4252     4252           
Impacted Files Coverage Δ
src/ai/backend/manager/models/base.py 53.80% <0.00%> (-0.88%) ⬇️
src/ai/backend/manager/api/auth.py 52.05% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fe578...4f4b709. Read the comment docs.

@achimnol achimnol merged commit 35ddf26 into main Apr 21, 2021
@achimnol achimnol deleted the fix/pytest-asyncio-compat-issue branch April 21, 2021 05:30
achimnol added a commit that referenced this pull request Apr 21, 2021
…handling event loops for fixtures (#423)

* pytest-asyncio 0.15 introduced a new way to close event loops
  after each test and that broke the test fixtures that uses
  internally separate event loops (e.g., `asyncio.run()`)
* The future release of pytest-asyncio will fix the issue, but
  for meanwhile we need to pin down its version.

Backported-From: main
Backported-To: 21.03
achimnol added a commit that referenced this pull request Apr 21, 2021
…handling event loops for fixtures (#423)

* pytest-asyncio 0.15 introduced a new way to close event loops
  after each test and that broke the test fixtures that uses
  internally separate event loops (e.g., `asyncio.run()`)
* The future release of pytest-asyncio will fix the issue, but
  for meanwhile we need to pin down its version.

Backported-From: main
Backported-To: 20.09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant