This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: do not collect data for utilization idle checker when interval is not passed #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 48.58% 48.54% -0.04%
==========================================
Files 52 52
Lines 8636 8643 +7
==========================================
Hits 4196 4196
- Misses 4440 4447 +7
Continue to review full report at Codecov.
|
achimnol
deleted the
fix/reduced-utilization-time-window-when-there-are-multiple-manager-processes
branch
achimnol
pushed a commit
that referenced
this pull request
Jun 28, 2021
…s not passed (#441) * On HA setups, there are multiple (n) manager instances who collects the utilization data and it accumulates the utilization data points n times faster, leading n times shorter check interval. * This patch fixes it by checking the last collection time as well as the window size calculate from the number of data points and the collection interval. Backported-From: main Backported-To: 21.03
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic not to collect data points for utilization idle checker when the current time does not exceed the sum of the last collect time and the
intervalof the checker. Previously, each Manager process independently collects data without considering the interval, which results in a much faster session termination than intended.For example, the idle timeout is reduced by half if there are two Managers since they collect the data twice within the configured interval. By the same logic, if there are three Managers, the idle timeout is reduced by one-third.
So, this PR logs the last collect time and does not collect the data when the
intervalis not passed from it.