Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Missing GQL root query field updates #453

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Conversation

achimnol
Copy link
Member

This is a follow-up to #449

* fix: Add filter/order args to storage_volume_list, though they are
  ignored as internal implementation is not based on SQL.
@achimnol achimnol added this to the 20.09 milestone Jul 19, 2021
@achimnol achimnol added the bug label Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #453 (cbfd2eb) into main (3f73610) will increase coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files          54       54           
  Lines        8864     8869    +5     
=======================================
+ Hits         4309     4312    +3     
- Misses       4555     4557    +2     
Impacted Files Coverage Δ
src/ai/backend/manager/models/gql.py 48.25% <0.00%> (ø)
src/ai/backend/manager/models/kernel.py 44.56% <0.00%> (ø)
src/ai/backend/manager/models/keypair.py 51.40% <ø> (ø)
src/ai/backend/manager/models/storage.py 45.03% <60.00%> (+0.51%) ⬆️
src/ai/backend/manager/models/minilang/ordering.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f73610...cbfd2eb. Read the comment docs.

@achimnol achimnol merged commit 2225f48 into main Jul 19, 2021
@achimnol achimnol deleted the fix/followup-for-pr449 branch July 19, 2021 07:52
achimnol added a commit that referenced this pull request Jul 19, 2021
* fix: Add filter/order args to storage_volume_list, though they are
  ignored as internal implementation is not based on SQL.
* fix: typo in default ordering for session lists
* fix: Add email & user_id to keypair query filter

Backported-From: main (21.09)
Backported-To: 21.03
achimnol added a commit that referenced this pull request Jul 19, 2021
* fix: Add filter/order args to storage_volume_list, though they are
  ignored as internal implementation is not based on SQL.
* fix: typo in default ordering for session lists
* fix: Add email & user_id to keypair query filter

Backported-From: main (21.09)
Backported-To: 20.09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant