Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Fix duplicate codes and add duplicate target dir check for mount_map when creating sessions #461

Merged
merged 8 commits into from
Jul 30, 2021
Merged

fix: Fix duplicate codes and add duplicate target dir check for mount_map when creating sessions #461

merged 8 commits into from
Jul 30, 2021

Conversation

Taewan-P
Copy link
Contributor

@Taewan-P Taewan-P commented Jul 27, 2021

Internal Ticket: OP#1432
This PR removes:

  • Duplicate codes of checking the validity of mount_map argument.

This PR adds:

  • Check duplicate alias folder name.
  • Check existing folder name as alias name.
  • Check empty alias name.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #461 (1e90e04) into main (f632148) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   48.65%   48.65%           
=======================================
  Files          54       54           
  Lines        8877     8877           
=======================================
  Hits         4319     4319           
  Misses       4558     4558           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f632148...1e90e04. Read the comment docs.

Taewan-P added 3 commits July 29, 2021 01:37
Check for any...
 * Duplicate alias folder name
 * Existing folder name as alias name
@Taewan-P Taewan-P changed the title fix: Fix duplicate codes and add duplicate target dir check for mount_map when creating sessions fix: Fix duplicate codes and add duplicate target dir check for mount_map when creating sessions Jul 28, 2021
@Taewan-P Taewan-P requested a review from achimnol July 28, 2021 17:06
@Taewan-P Taewan-P marked this pull request as ready for review July 28, 2021 17:10
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@achimnol achimnol merged commit 9650fc5 into lablup:main Jul 30, 2021
@achimnol achimnol added this to the 20.09 milestone Jul 30, 2021
@achimnol achimnol added the bug label Jul 30, 2021
achimnol pushed a commit that referenced this pull request Jul 30, 2021
…t_map` when creating sessions (#461)

* Checks the following conditions:
  - Duplicate aliases
  - Existing folder name as aliases
  - Empty aliases

Backported-From: main (21.09)
Backported-To: 21.03
achimnol pushed a commit that referenced this pull request Jul 30, 2021
…t_map` when creating sessions (#461)

* Checks the following conditions:
  - Duplicate aliases
  - Existing folder name as aliases
  - Empty aliases

Backported-From: main (21.09)
Backrpoted-To: 20.09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants