This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
fix: Fix duplicate codes and add duplicate target dir check for mount_map
when creating sessions
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 48.65% 48.65%
=======================================
Files 54 54
Lines 8877 8877
=======================================
Hits 4319 4319
Misses 4558 4558 Continue to review full report at Codecov.
|
Check for any... * Duplicate alias folder name * Existing folder name as alias name
mount_map
when creating sessions
achimnol
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
achimnol
pushed a commit
that referenced
this pull request
Jul 30, 2021
…t_map` when creating sessions (#461) * Checks the following conditions: - Duplicate aliases - Existing folder name as aliases - Empty aliases Backported-From: main (21.09) Backported-To: 21.03
achimnol
pushed a commit
that referenced
this pull request
Jul 30, 2021
…t_map` when creating sessions (#461) * Checks the following conditions: - Duplicate aliases - Existing folder name as aliases - Empty aliases Backported-From: main (21.09) Backrpoted-To: 20.09
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Ticket: OP#1432
This PR removes:
mount_map
argument.This PR adds: