This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: Always set the scaling group when creating sessions #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
achimnol
commented
Aug 27, 2021
achimnol
commented
- Setting it as None may schedule the session in non-allowed scaling groups.
* Setting it as None may schedule the session in non-allowed scaling groups.
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 48.69% 48.66% -0.03%
==========================================
Files 54 54
Lines 8874 8879 +5
==========================================
Hits 4321 4321
- Misses 4553 4558 +5
Continue to review full report at Codecov.
|
achimnol
added a commit
that referenced
this pull request
Aug 27, 2021
* Setting it as None may schedule the session in non-allowed scaling groups. * Add server-side warning log for scaling group fallback Backported-From: main (21.09) Backported-To: 21.03
achimnol
added a commit
that referenced
this pull request
Aug 27, 2021
* Setting it as None may schedule the session in non-allowed scaling groups. * Add server-side warning log for scaling group fallback Backported-From: main (21.09) Backported-To: 20.09
lizable
pushed a commit
that referenced
this pull request
Sep 15, 2021
* Setting it as None may schedule the session in non-allowed scaling groups. * Add server-side warning log for scaling group fallback
lizable
pushed a commit
that referenced
this pull request
Sep 15, 2021
* Setting it as None may schedule the session in non-allowed scaling groups. * Add server-side warning log for scaling group fallback
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.