Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Improve session/kernel event notification stability #495

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Nov 7, 2021

  • fix: Use proper txn isolation levels for session/kernel event subscribers
  • fix: Use proper txn isolation level when querying user info

@achimnol achimnol added this to the 21.03 milestone Nov 7, 2021
@achimnol achimnol added the bug label Nov 7, 2021
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #495 (1e6071e) into main (c9e6808) will increase coverage by 0.01%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   49.24%   49.26%   +0.01%     
==========================================
  Files          54       54              
  Lines        8928     8932       +4     
==========================================
+ Hits         4397     4400       +3     
- Misses       4531     4532       +1     
Impacted Files Coverage Δ
src/ai/backend/manager/models/keypair.py 51.60% <0.00%> (ø)
src/ai/backend/manager/api/events.py 36.04% <20.00%> (+0.21%) ⬆️
src/ai/backend/manager/plugin/error_monitor.py 64.40% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e6808...1e6071e. Read the comment docs.

@achimnol achimnol merged commit 9ccf1cb into main Nov 8, 2021
@achimnol achimnol deleted the fix/improve-event-notification-stability branch November 8, 2021 02:46
achimnol added a commit that referenced this pull request Nov 8, 2021
* fix: Use proper txn isolation levels for session/kernel event subscribers
* fix: Use proper txn isolation level when querying user info
* fix: Properly synchronize queue shutdown

Backported-From: main (21.09)
Backported-To: 21.03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant