Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Remove reusable caching for RPC peer objects #497

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

achimnol
Copy link
Member

  • This will increase overheads for individual RPC calls,
    but may prevent hanging RPC call issues.

* This will increase overheads for individual RPC calls,
  but may prevent hanging RPC call issues.
@achimnol achimnol added this to the 21.03 milestone Nov 12, 2021
@achimnol achimnol added the bug label Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #497 (328fe5f) into main (15acec7) will decrease coverage by 0.11%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   48.89%   48.78%   -0.12%     
==========================================
  Files          54       54              
  Lines        8908     8929      +21     
==========================================
  Hits         4356     4356              
- Misses       4552     4573      +21     
Impacted Files Coverage Δ
src/ai/backend/manager/registry.py 17.11% <9.09%> (-0.28%) ⬇️
src/ai/backend/manager/models/session_template.py 26.78% <0.00%> (-4.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15acec7...328fe5f. Read the comment docs.

@achimnol achimnol self-assigned this Nov 25, 2021
@achimnol
Copy link
Member Author

I'll merge this PR as it seems to stabilize some customer sites better.

@achimnol achimnol merged commit 2706d03 into main Nov 26, 2021
@achimnol achimnol deleted the fix/do-not-reuse-agent-peer-rpc-channels branch November 26, 2021 08:41
achimnol added a commit that referenced this pull request Nov 26, 2021
* This will increase overheads for individual RPC calls,
  but may prevent hanging RPC call issues.

Backported-From: main (21.09)
Backported-To: 21.03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant