This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: Avoid TooManySessions error when there is an exact match, not only prefix matches #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 48.84% 48.83% -0.02%
==========================================
Files 54 54
Lines 8947 8951 +4
==========================================
+ Hits 4370 4371 +1
- Misses 4577 4580 +3
Continue to review full report at Codecov.
|
|
lablup/backend.ai#297 |
achimnol
approved these changes
Dec 21, 2021
achimnol
changed the title
achimnol
pushed a commit
that referenced
this pull request
Dec 21, 2021
…ly prefix matches (#506) * Add one more query with `cond_equal_name` in addition to `cond_prefix_name`. The common case will still be the session ID prefix matching before matching names, so we expect the performance impact is minimal. Backported-From: main (22.03) Backported-To: 21.09
achimnol
pushed a commit
that referenced
this pull request
Dec 21, 2021
…ly prefix matches (#506) * Add one more query with `cond_equal_name` in addition to `cond_prefix_name`. The common case will still be the session ID prefix matching before matching names, so we expect the performance impact is minimal. Backported-From: main (22.03) Backported-To: 21.03
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request temporary solve the session_name matching problem (Too many sessions matched)
lablup/backend.ai#297