This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: declare down_task in TCPProxy to prevent AttributeError #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 48.42% 46.90% -1.53%
==========================================
Files 53 53
Lines 8729 9328 +599
==========================================
+ Hits 4227 4375 +148
- Misses 4502 4953 +451
Continue to review full report at Codecov.
|
achimnol
approved these changes
Jan 16, 2022
achimnol
pushed a commit
that referenced
this pull request
Jan 16, 2022
…rror (#519) Backported-From: main (22.03) Backported-To: 21.09
achimnol
pushed a commit
that referenced
this pull request
Jan 16, 2022
…rror (#519) Backported-From: main (22.03) Backported-To: 21.03
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases,
TCPProxyraises anAttributeErrorin proxying app requests like the image below.This PR just explicitly declare the
down_taskattribute in theTCPProxyclass to prevent the above issue.