Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: occupied slot not released when session creation fails #531

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

kyujin-cho
Copy link
Member

This PR closes lablup/backend.ai#315, by forcing resource usage recalculation when session creation is failed.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #531 (b2423fa) into main (20f748b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   48.88%   48.87%   -0.01%     
==========================================
  Files          54       54              
  Lines        9001     9002       +1     
==========================================
  Hits         4400     4400              
- Misses       4601     4602       +1     
Impacted Files Coverage Δ
src/ai/backend/manager/scheduler/dispatcher.py 25.40% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f748b...b2423fa. Read the comment docs.

@kyujin-cho kyujin-cho requested a review from achimnol February 8, 2022 06:53
@kyujin-cho kyujin-cho self-assigned this Feb 8, 2022
@kyujin-cho kyujin-cho added the bug label Feb 8, 2022
@kyujin-cho kyujin-cho added this to the 21.09 milestone Feb 8, 2022
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyujin-cho kyujin-cho changed the title fix: occupied slot not released when session creation is failed fix: occupied slot not released when session creation has been failed Feb 8, 2022
@kyujin-cho kyujin-cho changed the title fix: occupied slot not released when session creation has been failed fix: occupied slot not released when session creation fails Feb 8, 2022
@adrysn
Copy link
Member

adrysn commented Feb 10, 2022

Tested and it works well!

@achimnol achimnol merged commit 7978b8c into main Feb 14, 2022
@achimnol achimnol deleted the fix/release-failed-session-slot branch February 14, 2022 04:42
achimnol pushed a commit that referenced this pull request Feb 14, 2022
Backported-From: main (22.03)
Backported-To: 21.09
@achimnol achimnol modified the milestones: 21.09, 21.03 Feb 14, 2022
@achimnol
Copy link
Member

Since this is a bug fix, I'll backport it to 21.03 as well.

achimnol pushed a commit that referenced this pull request Feb 14, 2022
Backported-From: main (22.03)
Backported-To: 21.03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occupied slots are not released automatically when session creation is failed
3 participants