This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: migrate concurrency check to redis #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 49.33% 49.28% -0.05%
==========================================
Files 55 55
Lines 8991 9008 +17
==========================================
+ Hits 4436 4440 +4
- Misses 4555 4568 +13
Continue to review full report at Codecov.
|
824cd33
to
ba80375
Compare
b89f75a
to
d24c3de
Compare
* Specifying column means that it will count non-null values of that column. * In our cases we didn't intend it so remove the explicit columns.
achimnol
approved these changes
Mar 28, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the implementation of 1st approach in lablup/backend.ai#365
Test
TL; DR
Migrating concurrency check to redis works without malfunctions. Other tables such as
kernels
causes a bottleneck but this is another issue.Creating a
keypair_resource_usages
table occurs many bottlenecks and consequently raises canceled error.1
The number of sessions is too big to examine the change.
The bottleneck caused by

keypairs.concurrency_used
does not occur but another error appears.All sessions raise TimeoutError and CancelledError during methods
manager.registry.AgentRegistry.sync_kernel_stats
andmanager.registry.AgentRegistry.mark_agent_terminated
2
Result
Error
One error occurs in DB, kernels table.

3
Result
Error
Only one error occurs. This also occurs during updating kernels table.
