This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
feat: Allow mounting vfolder subdirectory into session container #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Check resource by root of subdirectory * feat: Apply mount info of root to its subdirectory
Codecov Report
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 49.04% 49.06% +0.02%
==========================================
Files 54 55 +1
Lines 9066 9155 +89
==========================================
+ Hits 4446 4492 +46
- Misses 4620 4663 +43
Continue to review full report at Codecov.
|
achimnol
changed the title
achimnol
suggested changes
Feb 18, 2022
* Introduce StructuredJSONObjectColumn and StructuredJSONObjectListColumn * Introduce UserScope * Extract out prepare_dotfiles() and prepare_vfolder_mounts() from enqueue_session() and merge 2 + cluster_size transactions into one transaction * Keep API-level compatibility despite of all above internal refactoring
* Implement more sanity checks
7 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: lablup/backend.ai#360
related: https://github.com/lablup/backend.ai-agent/pull/343
Let's allow using a "partial" view of a vfolder inside sessions.
For example, if a vfolder mystuff has a/b/c subdirectories, let's allow mounting mystuff/a/b as /home/work/bbb.
When vfolders are mounted, for verification existence of it db query is used. However, that have only top path of subdirectory and make object with necessary information to mount including only top path of subdirectory as folder name.
To solve this problem, after making other information to mount using top path of subdirectory edit only top path of folder names to full folder name including subdirectories.