Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Remove implicit trailing whitespace from the agents.architecture column #559

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

fregataa
Copy link
Member

alter table column type agents.archtecture from CHAR to String

@fregataa fregataa requested a review from kyujin-cho March 25, 2022 06:16
@fregataa fregataa self-assigned this Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #559 (69a9209) into main (3d5fda0) will increase coverage by 0.51%.
The diff coverage is 37.71%.

❗ Current head 69a9209 differs from pull request most recent head 68532af. Consider uploading reports for the commit 68532af to get more accurate results

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   48.82%   49.33%   +0.51%     
==========================================
  Files          54       55       +1     
  Lines        8951     8991      +40     
==========================================
+ Hits         4370     4436      +66     
+ Misses       4581     4555      -26     
Impacted Files Coverage Δ
src/ai/backend/manager/api/events.py 35.63% <0.00%> (-0.42%) ⬇️
src/ai/backend/manager/api/manager.py 37.26% <0.00%> (-0.63%) ⬇️
src/ai/backend/manager/models/domain.py 58.28% <0.00%> (ø)
src/ai/backend/manager/models/group.py 45.51% <0.00%> (ø)
src/ai/backend/manager/models/session_template.py 31.64% <0.00%> (ø)
src/ai/backend/manager/scheduler/dispatcher.py 24.73% <4.16%> (-0.80%) ⬇️
src/ai/backend/manager/api/utils.py 52.00% <9.09%> (-6.30%) ⬇️
src/ai/backend/manager/models/vfolder.py 33.57% <11.47%> (-6.62%) ⬇️
src/ai/backend/manager/registry.py 18.29% <12.50%> (+1.18%) ⬆️
src/ai/backend/manager/cli/image_impl.py 23.15% <23.15%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85d148...68532af. Read the comment docs.

@fregataa fregataa requested a review from achimnol March 28, 2022 01:36
@fregataa fregataa added the bug label Mar 28, 2022
@achimnol achimnol changed the title fix: alter agent arch column to str type fix: Remove implicit trailing whitespace from the agents.architecture column Mar 28, 2022
@achimnol achimnol merged commit 768aff2 into main Mar 28, 2022
@achimnol achimnol deleted the fix/alter-arch-col branch March 28, 2022 02:31
@achimnol achimnol added this to the 22.03 milestone Mar 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants