Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

feat: Session lifecycle event callback as webhook #567

Merged
merged 16 commits into from
Apr 5, 2022

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Mar 31, 2022

@achimnol achimnol added this to the 22.03 milestone Mar 31, 2022
@achimnol achimnol self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #567 (15b4ae3) into main (0388caf) will decrease coverage by 0.04%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   48.81%   48.76%   -0.05%     
==========================================
  Files          53       53              
  Lines        8999     9012      +13     
==========================================
+ Hits         4393     4395       +2     
- Misses       4606     4617      +11     
Impacted Files Coverage Δ
src/ai/backend/manager/models/kernel.py 44.60% <ø> (ø)
src/ai/backend/manager/registry.py 18.03% <ø> (ø)
src/ai/backend/manager/server.py 59.25% <ø> (-0.25%) ⬇️
src/ai/backend/manager/models/base.py 54.09% <46.15%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0388caf...15b4ae3. Read the comment docs.

@achimnol achimnol requested a review from adrysn March 31, 2022 07:46
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webhook request is successfully received by the MLOps pipeline server. However, the session event order is not guaranteed. For example, in the following Manager log, the started event is sent after the terminated event:

image

Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (bugfix part)

@achimnol achimnol merged commit e7a4119 into main Apr 5, 2022
@achimnol achimnol deleted the feature/session-event-webhook branch April 5, 2022 07:06
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants