This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
feat: Add KeyPairResourcePolicy.max_session_lifetime
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 48.51% 48.48% -0.04%
==========================================
Files 53 53
Lines 9125 9127 +2
==========================================
- Hits 4427 4425 -2
- Misses 4698 4702 +4
Continue to review full report at Codecov.
|
|
TODO: add a timer to periodically check expired sessions |
* Now we can naturally declare an intrinsic checker: SessionLifetimeChecker * Removed duplicate codes in different checkers by this refactoring! (such as policy cache) * Now all checkers are run inside a single read-only transaction. * If a checker decides to terminate a session, remaining checkers are safely skipped.
adrysn
suggested changes
Apr 24, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves lablup/backend.ai-internal#46