Add support for v2 (direct connection) wsproxy mode #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's automatically determine the request endpoint for wsproxy by implementing the status API (https://github.com/lablup/backend.ai-proxy-coordinator/pull/8#issuecomment-939627762). The new version of wsproxy anyway does not support v1 API, which is a breaking change, so there is no need to let users choose the API version. |
By using URL interface, we don't need to worry about a trailing slash. Ref) https://developer.mozilla.org/en-US/docs/Web/API/URL
… wsproxy version API
adrysn
requested review from
adrysn
and removed request for
agatha197 and
lizable
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for direct wsproxy connection mode, as described in lablup/backend.ai-manager#479.
User can try V2 proxy mode by enabling
UseV2Proxy(label subject to change) checkbox when opening app.To use V2 Proxy mode, wsproxy node address needs to be registered to corresponding scaling group.
This resolves #1144.