-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bind query params only for HTTP GET/DELETE methods #1727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
+ Coverage 85.77% 85.87% +0.10%
==========================================
Files 29 29
Lines 2017 2018 +1
==========================================
+ Hits 1730 1733 +3
+ Misses 181 180 -1
+ Partials 106 105 -1
Continue to review full report at Codecov.
|
@lammel have you checked https://github.blog/2020-05-06-new-from-satellite-2020-github-codespaces-github-discussions-securing-code-in-private-repositories-and-more/#discussions maybe it is worth checking. Echo official forum is full of spam and I thinks similar thing in github would be much easier to find and use |
Noted! This is being discussed already. |
Nice work. The tests cover all scenarios I could think off, thanks @aldas |
But why? :( What's wrong with query params in POST? :( Is there a way to force echo to parse query param for POST? Or I need to stay on older version? |
fixes #1670 and continues #1681 (comment) proposed changes
DefaultBinder.Bind() binds now query params to struct only for GET and DELETE methods. For POST/PUT/PATCH query params are not considered anymore. This restores pre v4.1.11 behavior.