-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor router for readability #1796
Conversation
… test cases with breakpoints)
Codecov Report
@@ Coverage Diff @@
## master #1796 +/- ##
==========================================
+ Coverage 89.56% 89.60% +0.03%
==========================================
Files 32 32
Lines 2646 2656 +10
==========================================
+ Hits 2370 2380 +10
Misses 178 178
Partials 98 98
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally readable router code. Awesome.
Great to see comments with diagrams to help understand the testcase. |
2 commits to separate these changes in history
NB: I took several tests from my own implementation and some of them have
FIXME
notes. These are to document behaviors where I think currently we are not routing correctly.For tests to highlight problematic param route + ending with slash - I will provide fix in separate PR as it is quite easy to fix.