From c6b5abb35abebc17f82b5f583607b0274199b5fe Mon Sep 17 00:00:00 2001
From: Chris Mackey <chris@ladybug.tools>
Date: Mon, 3 Jun 2024 14:28:16 -0700
Subject: [PATCH] fix(fan): Fix typo in fan ventilation schedule

Resolves https://github.com/ladybug-tools/honeybee-energy/issues/1012
---
 .github/workflows/ci.yaml         | 4 ++--
 .releaserc.json                   | 8 +++++++-
 lib/to_openstudio/ventcool/fan.rb | 2 +-
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 2c56f769..c56a0a44 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -31,9 +31,9 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: set up node  # we need node for for semantic release
-        uses: actions/setup-node@v3.6.0
+        uses: actions/setup-node@v4
         with:
-          node-version: 14.17.0
+          node-version: 22.2.0
       - name: install semantic-release
         run:
           npm install @semantic-release/exec
diff --git a/.releaserc.json b/.releaserc.json
index a966fe6b..4112130f 100644
--- a/.releaserc.json
+++ b/.releaserc.json
@@ -2,6 +2,12 @@
     "plugins": [
         "@semantic-release/commit-analyzer",
         "@semantic-release/release-notes-generator",
-        "@semantic-release/github"
+        [
+            "@semantic-release/github",
+            {
+                "successComment": false,
+                "failTitle": false
+            }
+        ]
     ]
 }
diff --git a/lib/to_openstudio/ventcool/fan.rb b/lib/to_openstudio/ventcool/fan.rb
index d9808607..8a8a5b99 100644
--- a/lib/to_openstudio/ventcool/fan.rb
+++ b/lib/to_openstudio/ventcool/fan.rb
@@ -105,7 +105,7 @@ def to_openstudio(openstudio_model, parent)
           vent_sch = openstudio_model.getScheduleByName(vent_control_hash[:schedule])
           unless vent_sch.empty?
             vent_sch_object = vent_sch.get
-            os_zone_vent.setOpeningAreaFractionSchedule(vent_sch_object)
+            os_zone_vent.setSchedule(vent_sch_object)
           end
         end
       end