Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add lagomLogback dependency and a logback.xml sample #37

Open
ignasi35 opened this issue Nov 8, 2018 · 1 comment
Open

Add lagomLogback dependency and a logback.xml sample #37

ignasi35 opened this issue Nov 8, 2018 · 1 comment

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Nov 8, 2018

It'd be good to have logback enabled and configured by default on the seeds.

@TimMoore
Copy link

TimMoore commented Nov 8, 2018

lagomLogback is added automatically by an sbt auto-plugin:

https://github.com/lagom/lagom/blob/ea8b417e9b520a6f66370be87dd3cf9d17a4c6a0/dev/sbt-plugin/src/main/scala/com/lightbend/lagom/sbt/LagomPlugin.scala#L690-L699

Lagom provides a default logback.xml configuration inside the framework JARs, so it isn't strictly necessary to have one inside the project..

That said, I do think it's worth including logback.xml explicitly in the templates, because right now it's totally invisible. The problem is: Lagom's default behavior uses slightly different configurations in development and production modes, but this isn't easy to replicate with an explicit config file in the project.

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

No branches or pull requests

3 participants