Skip to content
This repository was archived by the owner on May 9, 2019. It is now read-only.

Search feature completion #73

Open
ignasi35 opened this issue Apr 3, 2018 · 1 comment
Open

Search feature completion #73

ignasi35 opened this issue Apr 3, 2018 · 1 comment
Labels
help wanted Ready and waiting for a volunteer status:backlog

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Apr 3, 2018

online-auciton-scala's version of the Search service is not as complete as the java equivalent in online-auction-java. For starters: there's no UI.

As raised in #68, there was a runtime issue fixed in #72. But #72 exposed another runtime issue:

$ curl -d'{"keywords":"chair","maxPrice":10, "currency":"USD"}' -X POST -H "Content-Type: application/json" "http://localhost:9000/api/search?pageNo=1&pageSize=10"

returns:

{"name":"UndeserializableException","detail":"{\"error\":{\"root_cause\":[{\"type\":\"parsing_exception\",\"reason\":\"[itemStatus] query malformed, no start_object after query name\",\"line\":1,\"col\":63}],\"type\":\"parsing_exception\",\"reason\":\"[itemStatus] query malformed, no start_object after query name\",\"line\":1,\"col\":63},\"status\":400}"}
@TimMoore TimMoore added the help wanted Ready and waiting for a volunteer label Jun 18, 2018
This was referenced Mar 23, 2019
@ryanhanks
Copy link
Contributor

ryanhanks commented Mar 23, 2019

It looks like we have two tasks at-hand here:

  1. Build a UI for searching auction items
  2. Address runtime issue in SearchService.search (I've created Fix-up Elasticsearch integration #112 to discuss this separately).

When #112 is resolved, we should take a look at #113, which introduces a Search UI based on the Java implementation.

Let me know if you have any questions!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
help wanted Ready and waiting for a volunteer status:backlog
Development

No branches or pull requests

4 participants